]> git.ipfire.org Git - thirdparty/lxc.git/commitdiff
attach: silence stdio permission adjust warnings 3577/head
authorChristian Brauner <christian.brauner@ubuntu.com>
Thu, 5 Nov 2020 19:25:29 +0000 (20:25 +0100)
committerChristian Brauner <christian.brauner@ubuntu.com>
Thu, 5 Nov 2020 19:25:29 +0000 (20:25 +0100)
Closes: #3576.
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
src/lxc/attach.c
src/lxc/utils.c

index acbffa238d253b03381a92283840335f369a3aef..cfddf9b36a234bb046b65f5e28099d284ae35b73 100644 (file)
@@ -883,7 +883,7 @@ static int attach_child_main(struct attach_clone_payload *payload)
        /* Make sure that the processes STDIO is correctly owned by the user that we are switching to */
        ret = fix_stdio_permissions(new_uid);
        if (ret)
-               WARN("Failed to adjust stdio permissions");
+               INFO("Failed to adjust stdio permissions");
 
        if (!lxc_switch_uid_gid(new_uid, new_gid))
                goto on_error;
index baf80b7f5cbc0aee625d8a0fb0087933e41d81af..fdf437ef3545cff0ac8c7e9994314992b3b737e9 100644 (file)
@@ -1885,11 +1885,11 @@ int fix_stdio_permissions(uid_t uid)
 
        devnull_fd = open_devnull();
        if (devnull_fd < 0)
-               return log_warn_errno(-1, errno, "Failed to open \"/dev/null\"");
+               return log_trace_errno(-1, errno, "Failed to open \"/dev/null\"");
 
        ret = fstat(devnull_fd, &st_null);
        if (ret)
-               return log_warn_errno(-errno, errno, "Failed to stat \"/dev/null\"");
+               return log_trace_errno(-errno, errno, "Failed to stat \"/dev/null\"");
 
        for (int i = 0; i < ARRAY_SIZE(std_fds); i++) {
                ret = fstat(std_fds[i], &st);
@@ -1904,14 +1904,15 @@ int fix_stdio_permissions(uid_t uid)
 
                ret = fchown(std_fds[i], uid, st.st_gid);
                if (ret) {
-                       SYSWARN("Failed to chown standard I/O file descriptor %d to uid %d and gid %d",
-                               std_fds[i], uid, st.st_gid);
+                       TRACE("Failed to chown standard I/O file descriptor %d to uid %d and gid %d",
+                             std_fds[i], uid, st.st_gid);
                        fret = -1;
+                       continue;
                }
 
                ret = fchmod(std_fds[i], 0700);
                if (ret) {
-                       SYSWARN("Failed to chmod standard I/O file descriptor %d", std_fds[i]);
+                       TRACE("Failed to chmod standard I/O file descriptor %d", std_fds[i]);
                        fret = -1;
                }
        }