terminal: fail on unknown error during TIOCGPTPEER

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

diff --git a/src/lxc/terminal.c b/src/lxc/terminal.c
index dcdb51df5f51c769a0194264c5cfcf619bb9c6a9..cdb44956c539b10cca4a20e6341e49da8bd9165c 100644 (file)
--- a/src/lxc/terminal.c
+++ b/src/lxc/terminal.c
@@ -944,9 +944,10 @@ int lxc_devpts_terminal(int devpts_fd, int *ret_ptx, int *ret_pty,
                        break;
                default:
                        SYSWARN("Failed to allocate new pty device");
-                       break;
+                       return -errno;
                }
 
+               /* The caller tells us that they trust the devpts instance. */
                if (require_tiocgptpeer)
                        return ret_errno(ENODEV);
        }