]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
smb: add detect tx flags shim for smb (non-rust) 4414/head
authorVictor Julien <victor@inliniac.net>
Tue, 3 Dec 2019 06:09:19 +0000 (07:09 +0100)
committerVictor Julien <victor@inliniac.net>
Tue, 3 Dec 2019 18:53:20 +0000 (19:53 +0100)
src/app-layer-smb.c

index 5a86ec730b25a7c48eb0e14ea9b722600abb4a8b..f7cee1292cd6f394c933836e83fa3abe4f9f1620 100644 (file)
@@ -1510,6 +1510,19 @@ static int SMBGetAlstateProgress(void *tx, uint8_t direction)
     return 0;
 }
 
+/* Not implemented. This parser doesn't really support transactions
+ * so we need to re-inspect the tx (state really) to avoid FNs. */
+static uint64_t SMBGetTxDetectFlags(void *vtx, uint8_t dir)
+{
+    return 0;
+}
+
+/* Not implemented. See SMBGetTxDetectFlags */
+static void SMBSetTxDetectFlags(void *vtx, uint8_t dir, uint64_t flags)
+{
+    /* no-op */
+}
+
 #define SMB_PROBING_PARSER_MIN_DEPTH 8
 
 static uint16_t SMBProbingParser(Flow *f, uint8_t *input, uint32_t ilen)
@@ -1608,6 +1621,8 @@ void RegisterSMBParsers(void)
 
         AppLayerParserRegisterDetectStateFuncs(IPPROTO_TCP, ALPROTO_SMB,
                                                SMBGetTxDetectState, SMBSetTxDetectState);
+        AppLayerParserRegisterDetectFlagsFuncs(IPPROTO_TCP, ALPROTO_SMB,
+                                               SMBGetTxDetectFlags, SMBSetTxDetectFlags);
 
         AppLayerParserRegisterGetTx(IPPROTO_TCP, ALPROTO_SMB, SMBGetTx);