]> git.ipfire.org Git - thirdparty/dnspython.git/commitdiff
Use min() for min_ttl computations. 550/head
authorBob Halley <halley@dnspython.org>
Tue, 21 Jul 2020 23:01:32 +0000 (16:01 -0700)
committerBob Halley <halley@dnspython.org>
Tue, 21 Jul 2020 23:01:32 +0000 (16:01 -0700)
dns/message.py

index 29fca22b19e7da3349b250c941626dc89122dd0f..f4ff3fc8904f36b9dc6fa0cb6345c7edeb88a3c2 100644 (file)
@@ -745,8 +745,7 @@ class QueryMessage(Message):
             try:
                 rrset = self.find_rrset(self.answer, qname, question.rdclass,
                                         question.rdtype)
-                if rrset.ttl < min_ttl:
-                    min_ttl = rrset.ttl
+                min_ttl = min(min_ttl, rrset.ttl)
                 break
             except KeyError:
                 if question.rdtype != dns.rdatatype.CNAME:
@@ -754,8 +753,7 @@ class QueryMessage(Message):
                         crrset = self.find_rrset(self.answer, qname,
                                                  question.rdclass,
                                                  dns.rdatatype.CNAME)
-                        if crrset.ttl < min_ttl:
-                            min_ttl = crrset.ttl
+                        min_ttl = min(min_ttl, crrset.ttl)
                         for rd in crrset:
                             qname = rd.target
                             break
@@ -778,10 +776,7 @@ class QueryMessage(Message):
                     srrset = self.find_rrset(self.authority, auname,
                                              question.rdclass,
                                              dns.rdatatype.SOA)
-                    if srrset.ttl < min_ttl:
-                        min_ttl = srrset.ttl
-                    if srrset[0].minimum < min_ttl:
-                        min_ttl = srrset[0].minimum
+                    min_ttl = min(min_ttl, srrset.ttl, srrset[0].minimum)
                     break
                 except KeyError:
                     try: