No Scroll Animation when scroll_speed = 0

While implementing Joyride on our site we noticed when setting scroll_speed to 0 per your documentation, Joyride would still scroll, but do it instantly. This small adjustment fixed the issue for us.

diff --git a/js/foundation/foundation.joyride.js b/js/foundation/foundation.joyride.js
index a67505d38f0c94d70db11dbb2099fd09cce3652b..ebb83dbccb7fe6accb1315392533a38449d7b90b 100644 (file)
--- a/js/foundation/foundation.joyride.js
+++ b/js/foundation/foundation.joyride.js
@@ -460,7 +460,7 @@
       window_half = $(window).height() / 2;
       tipOffset = Math.ceil(this.settings.$target.offset().top - window_half + this.settings.$next_tip.outerHeight());
 
-      if (tipOffset != 0) {
+      if (this.settings.scroll_speed !== 0 && tipOffset != 0) {
         $('html, body').stop().animate({
           scrollTop: tipOffset
         }, this.settings.scroll_speed, 'swing');