]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
config: fix null dereference in MacSetRegisterFlowStorage 6212/head
authorPhilippe Antoine <contact@catenacyber.fr>
Fri, 11 Jun 2021 12:13:44 +0000 (14:13 +0200)
committerVictor Julien <victor@inliniac.net>
Mon, 21 Jun 2021 16:08:06 +0000 (18:08 +0200)
Crash happens with
--set outputs.eve-json.types.files.force-magic=yes

(cherry picked from commit 8bf653054025e6297f05ec211a0baa44cf795704)

src/util-macset.c

index 30e6c6b3439cccf5345d4c51ea8621fb3ad64e90..fbffd6ce5c505a6d79bf509e9080348bee1ca7bd 100644 (file)
@@ -66,7 +66,7 @@ void MacSetRegisterFlowStorage(void)
        has the ethernet setting enabled */
     if (root != NULL) {
         TAILQ_FOREACH(node, &root->head, next) {
-            if (strcmp(node->val, "eve-log") == 0) {
+            if (node->val && strcmp(node->val, "eve-log") == 0) {
                 const char *enabled = ConfNodeLookupChildValue(node->head.tqh_first, "enabled");
                 if (enabled != NULL && ConfValIsTrue(enabled)) {
                     const char *ethernet = ConfNodeLookupChildValue(node->head.tqh_first, "ethernet");