]> git.ipfire.org Git - thirdparty/krb5.git/commitdiff
Fix minor leak in kdb5_util purge_mkeys 798/head
authorGreg Hudson <ghudson@mit.edu>
Tue, 19 Jun 2018 17:03:05 +0000 (13:03 -0400)
committerGreg Hudson <ghudson@mit.edu>
Wed, 20 Jun 2018 15:00:02 +0000 (11:00 -0400)
In kdb5_purge_mkeys(), if krb5_dbe_update_mkey_aux() fails, use the
cleanup label to free any allocated memory instead of returning
immediately.  Reported by Bean Zhang.

ticket: 8702

src/kadmin/dbutil/kdb5_mkey.c

index 2efe3176e81b53875173d92d3d4d93fd75777b2b..5395a6070cee1ec2675f535699249981c5583546 100644 (file)
@@ -1297,7 +1297,7 @@ kdb5_purge_mkeys(int argc, char *argv[])
         com_err(progname, retval,
                 _("while updating mkey_aux data for master principal entry"));
         exit_status++;
-        return;
+        goto cleanup_return;
     }
 
     if ((retval = krb5_timeofday(util_context, &now))) {