]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
detect: apply drops to tunnel root 8177/head
authorVictor Julien <vjulien@oisf.net>
Wed, 16 Nov 2022 09:44:13 +0000 (10:44 +0100)
committerVictor Julien <vjulien@oisf.net>
Wed, 16 Nov 2022 20:04:40 +0000 (21:04 +0100)
`PacketDrop` applied a DROP to the current packet unconditionally,
while in tunnel/encapsulated cases the DROP should have been applied
to the root packet.

Fixes: 6742ecbc9e87 ("decode: make PacketDrop use action as parameter")
Bug: #5600.

src/decode.h

index 223e3c67ef44abb67dae74e4b2c8132f2225ad13..e141acb9f8880e32a97d3ba16d735d1abae63562 100644 (file)
@@ -916,7 +916,7 @@ static inline void PacketDrop(Packet *p, const uint8_t action, enum PacketDropRe
     if (p->drop_reason == PKT_DROP_REASON_NOT_SET)
         p->drop_reason = (uint8_t)r;
 
-    PACKET_UPDATE_ACTION(p, action);
+    PacketUpdateAction(p, action);
 }
 #define PACKET_DROP(p) PacketDrop((p), PKT_DROP_REASON_NOT_SET)