]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
rec: Don't copy the records when scanning for CNAME loops 9248/head
authorRemi Gacogne <remi.gacogne@powerdns.com>
Tue, 9 Jun 2020 15:19:09 +0000 (17:19 +0200)
committerOtto Moerbeek <otto.moerbeek@open-xchange.com>
Tue, 16 Jun 2020 14:36:43 +0000 (16:36 +0200)
pdns/syncres.cc

index 71d4e39bd0becedd832d420b258bfc4f9a7dadaf..0aaa46abe3021021d4613208b19aa5fb82291001 100644 (file)
@@ -1168,7 +1168,7 @@ void SyncRes::updateValidationStatusInCache(const DNSName &qname, const QType& q
 
 static bool scanForCNAMELoop(const DNSName& name, const vector<DNSRecord>& records)
 {
-  for (const auto record: records) {
+  for (const auto& record: records) {
     if (record.d_type == QType::CNAME && record.d_place == DNSResourceRecord::ANSWER) {
       if (name == record.d_name) {
         return true;