string-driven getters and setters

diff --git a/moment.js b/moment.js
index bdc4c425b28d82ff8b1db61390876c833a93db51..7ace2c008ef5232d4df7593d19b7f15cf128eedf 100644 (file)
--- a/moment.js
+++ b/moment.js
@@ -1459,6 +1459,16 @@
             return input == null ? this.day() || 7 : this.day(this.day() % 7 ? input : input - 7);
         },
 
+        get : function (units) {
+            units = normalizeUnits(units);
+            return this[units.toLowerCase() + 's']();
+        },
+
+        set : function (units, value) {
+            units = normalizeUnits(units);
+            this[units.toLowerCase() + 's'](value);
+        },
+
         // If passed a language key, it will set the language for this
         // instance.  Otherwise, it will return the language configuration
         // variables for this instance.

diff --git a/test/moment/getters_setters.js b/test/moment/getters_setters.js
index 49207b9502535454871ae0222b32db51e1ff17b5..6cb661a80e65ed7b8ea0970f75e7e48b0df1e9b1 100644 (file)
--- a/test/moment/getters_setters.js
+++ b/test/moment/getters_setters.js
@@ -16,6 +16,21 @@ exports.getters_setters = {
         test.done();
     },
 
+    "getters programmatic" : function (test) {
+        test.expect(8);
+
+        var a = moment([2011, 9, 12, 6, 7, 8, 9]);
+        test.equal(a.get('year'), 2011, 'year');
+        test.equal(a.get('month'), 9, 'month');
+        test.equal(a.get('date'), 12, 'date');
+        test.equal(a.get('day'), 3, 'day');
+        test.equal(a.get('hour'), 6, 'hour');
+        test.equal(a.get('minute'), 7, 'minute');
+        test.equal(a.get('second'), 8, 'second');
+        test.equal(a.get('milliseconds'), 9, 'milliseconds');
+        test.done();
+    },
+
     "setters plural" : function (test) {
         test.expect(8);
 
@@ -88,6 +103,34 @@ exports.getters_setters = {
         test.done();
     },
 
+    "setter programmatic" : function (test) {
+        test.expect(9);
+
+        var a = moment();
+        a.set('year', 2011);
+        a.set('month', 9);
+        a.set('date', 12);
+        a.set('hours', 6);
+        a.set('minutes', 7);
+        a.set('seconds', 8);
+        a.set('milliseconds', 9);
+        test.equal(a.year(), 2011, 'year');
+        test.equal(a.month(), 9, 'month');
+        test.equal(a.date(), 12, 'date');
+        test.equal(a.day(), 3, 'day');
+        test.equal(a.hours(), 6, 'hour');
+        test.equal(a.minutes(), 7, 'minute');
+        test.equal(a.seconds(), 8, 'second');
+        test.equal(a.milliseconds(), 9, 'milliseconds');
+
+        // Test month() behavior. See https://github.com/timrwood/moment/pull/822
+        a = moment('20130531', 'YYYYMMDD');
+        a.month(3);
+        test.equal(a.month(), 3, 'month edge case');
+
+        test.done();
+    },
+
     "setters strings" : function (test) {
         test.expect(7);