Only standard modules register xlats with their own name

Without this, if a virtual server, for example, has the same name as a
module which registers an xlat in its name, then, during server
shutdown, removing the process module for the virtual server attempts to
unregister the xlat which it doesn't own and leads to a seg fault.

diff --git a/src/lib/server/module.c b/src/lib/server/module.c
index 47bbb3212dea492356baeaa612841119e44ecdff..edaa452e558b9cf6fd0f8ba8005546d1eb09f12d 100644 (file)
--- a/src/lib/server/module.c
+++ b/src/lib/server/module.c
@@ -1533,7 +1533,7 @@ static int _module_instance_free(module_instance_t *mi)
         *      Remove all xlat's registered to module instance.
         */
        if (mi->data) {
-               xlat_func_unregister(mi->name);
+               if (mi->module->type == DL_MODULE_TYPE_MODULE) xlat_func_unregister(mi->name);
                xlat_func_unregister_module(mi);
        }