From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Sun, 3 Nov 2019 19:34:10 +0000 (-0600)
Subject: CID 1455245
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=000622486fcb38a8ac67372f3932ffb7684e5268;p=thirdparty%2Ffreeradius-server.git

CID 1455245
---

diff --git a/src/modules/proto_control/radmin.c b/src/modules/proto_control/radmin.c
index a2cf6a9ff02..4b33498f37c 100644
--- a/src/modules/proto_control/radmin.c
+++ b/src/modules/proto_control/radmin.c
@@ -456,34 +456,17 @@ static char *my_readline(char const *prompt, FILE *fp_in, FILE *fp_out)
 		fprintf(stderr, "Input line too long\n");
 		fr_exit_now(EXIT_FAILURE);
 	}
-
 	*p = '\0';
 
-	/*
-	 *	Strip off leading spaces.
-	 */
-	for (p = line; *p != '\0'; p++) {
-		if ((p[0] == ' ') ||
-		    (p[0] == '\t')) {
-			line = p + 1;
-			continue;
-		}
-
-		/*
-		 *	Return an empty string.
-		 */
-		if (p[0] == '#') {
-			line[0] = '\0';
-			break;
-		}
-
-		break;
-	}
+	fr_skip_whitespace(line);
 
 	/*
 	 *	Comments: keep going.
 	 */
-	if (!line) return line;
+	if (line[0] == '#') {
+		*line = '\0';
+		return line;
+	}
 
 	/*
 	 *	Strip off CR / LF