From: Simon McVittie <smcv@collabora.com>
Date: Fri, 31 Aug 2018 17:58:06 +0000 (+0100)
Subject: tests: Remove unnecessary casts
X-Git-Tag: dbus-1.13.8~23^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=000ef530e8a676ce3ef70645453c4026404fde77;p=thirdparty%2Fdbus.git

tests: Remove unnecessary casts

If we have a variable "Type value;" then casting &value to (Type *) is
not useful, because it has that type already; it can only hide errors.

Signed-off-by: Simon McVittie <smcv@collabora.com>
---

diff --git a/dbus/dbus-marshal-recursive-util.c b/dbus/dbus-marshal-recursive-util.c
index 704757b79..f71b8e927 100644
--- a/dbus/dbus-marshal-recursive-util.c
+++ b/dbus/dbus-marshal-recursive-util.c
@@ -2109,8 +2109,7 @@ int16_read_value (TestTypeNode   *node,
 
   check_expected_type (reader, node->klass->typecode);
 
-  _dbus_type_reader_read_basic (reader,
-                                (dbus_int16_t*) &v);
+  _dbus_type_reader_read_basic (reader, &v);
 
   _dbus_assert (v == int16_from_seed (seed));
 
@@ -2236,8 +2235,7 @@ int32_read_value (TestTypeNode   *node,
 
   check_expected_type (reader, node->klass->typecode);
 
-  _dbus_type_reader_read_basic (reader,
-                                (dbus_int32_t*) &v);
+  _dbus_type_reader_read_basic (reader, &v);
 
   _dbus_assert (v == int32_from_seed (seed));
 
@@ -2351,8 +2349,7 @@ int64_read_value (TestTypeNode   *node,
 
   check_expected_type (reader, node->klass->typecode);
 
-  _dbus_type_reader_read_basic (reader,
-                                (dbus_int64_t*) &v);
+  _dbus_type_reader_read_basic (reader, &v);
 
   _dbus_assert (v == int64_from_seed (seed));
 
@@ -2621,8 +2618,7 @@ double_read_value (TestTypeNode   *node,
 
   check_expected_type (reader, node->klass->typecode);
 
-  _dbus_type_reader_read_basic (reader,
-                                (double*) &v);
+  _dbus_type_reader_read_basic (reader, &v);
 
   expected = double_from_seed (seed);
 
@@ -2715,8 +2711,7 @@ object_path_read_value (TestTypeNode   *node,
 
   check_expected_type (reader, node->klass->typecode);
 
-  _dbus_type_reader_read_basic (reader,
-                                (const char **) &v);
+  _dbus_type_reader_read_basic (reader, &v);
 
   object_path_from_seed (buf, seed);
 
@@ -2786,8 +2781,7 @@ signature_read_value (TestTypeNode   *node,
 
   check_expected_type (reader, node->klass->typecode);
 
-  _dbus_type_reader_read_basic (reader,
-                                (const char **) &v);
+  _dbus_type_reader_read_basic (reader, &v);
 
   signature_from_seed (buf, seed);
 
@@ -3412,8 +3406,7 @@ dict_read_or_set_value (TestTypeNode   *node,
               
               check_expected_type (&entry_sub, DBUS_TYPE_INT32);
 
-              _dbus_type_reader_read_basic (&entry_sub,
-                                            (dbus_int32_t*) &v);
+              _dbus_type_reader_read_basic (&entry_sub, &v);
 
               _dbus_assert (v == int32_from_seed (seed + i));