From: Michael Brown <mcb30@etherboot.org>
Date: Mon, 29 Sep 2008 00:00:14 +0000 (+0100)
Subject: [gdb] Fix a compiler warning that shows up only when assertions are enabled
X-Git-Tag: v0.9.5~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0015601f0b5c0d677450c1dc507a261d5ca3012d;p=thirdparty%2Fipxe.git

[gdb] Fix a compiler warning that shows up only when assertions are enabled

gcc should (I think) be warning about this anyway, but seems to do so
only when assertions are enabled for this object.
---

diff --git a/src/arch/i386/core/gdbmach.c b/src/arch/i386/core/gdbmach.c
index 26fab609e..5e72e4d08 100644
--- a/src/arch/i386/core/gdbmach.c
+++ b/src/arch/i386/core/gdbmach.c
@@ -60,10 +60,10 @@ static struct hwbp *gdbmach_find_hwbp ( int type, unsigned long addr, size_t len
 }
 
 static void gdbmach_commit_hwbp ( struct hwbp *bp ) {
-	int regnum = bp - hwbps;
+	unsigned int regnum = bp - hwbps;
 
 	/* Set breakpoint address */
-	assert ( regnum >= 0 && regnum < sizeof hwbps / sizeof hwbps [ 0 ] );
+	assert ( regnum < ( sizeof hwbps / sizeof hwbps [ 0 ] ) );
 	switch ( regnum ) {
 		case 0:
 			__asm__ __volatile__ ( "movl %0, %%dr0\n" : : "r" ( bp->addr ) );