From: Jim Meyering <meyering@redhat.com>
Date: Tue, 18 May 2010 08:11:23 +0000 (+0200)
Subject: ebiptablesWriteToTempFile: don't close a negative file descriptor
X-Git-Tag: v0.8.2~257
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0058184c4e42d80298ed8a55f436e981239dba72;p=thirdparty%2Flibvirt.git

ebiptablesWriteToTempFile: don't close a negative file descriptor

* src/nwfilter/nwfilter_ebiptables_driver.c (ebiptablesWriteToTempFile):
Skip the close if "fd" is negative.
---

diff --git a/src/nwfilter/nwfilter_ebiptables_driver.c b/src/nwfilter/nwfilter_ebiptables_driver.c
index 63bcbd7402..ae21906122 100644
--- a/src/nwfilter/nwfilter_ebiptables_driver.c
+++ b/src/nwfilter/nwfilter_ebiptables_driver.c
@@ -2245,7 +2245,8 @@ ebiptablesWriteToTempFile(const char *string) {
 
 err_exit:
     VIR_FREE(header);
-    close(fd);
+    if (fd >= 0)
+        close(fd);
     unlink(filename);
     return NULL;
 }