From: Stephen Finucane <stephen@that.guru>
Date: Thu, 12 Mar 2020 15:11:09 +0000 (+0000)
Subject: tests: Add tests for invalid cover/patch IDs
X-Git-Tag: v2.2.0-rc2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=00808edcfe99689324dc6b28ef1b70dd4d7ab224;p=thirdparty%2Fpatchwork.git

tests: Add tests for invalid cover/patch IDs

Signed-off-by: Stephen Finucane <stephen@that.guru>
Related: #343
---

diff --git a/patchwork/tests/test_detail.py b/patchwork/tests/test_detail.py
index 32fbfaf7..92fe2d7e 100644
--- a/patchwork/tests/test_detail.py
+++ b/patchwork/tests/test_detail.py
@@ -9,6 +9,7 @@ from django.urls import reverse
 from patchwork.tests.utils import create_comment
 from patchwork.tests.utils import create_cover
 from patchwork.tests.utils import create_patch
+from patchwork.tests.utils import create_project
 
 
 class CoverLetterViewTest(TestCase):
@@ -50,6 +51,23 @@ class CoverLetterViewTest(TestCase):
         response = self.client.get(requested_url)
         self.assertRedirects(response, redirect_url)
 
+    def test_invalid_project_id(self):
+        requested_url = reverse(
+            'cover-detail',
+            kwargs={'project_id': 'foo', 'msgid': 'bar'},
+        )
+        response = self.client.get(requested_url)
+        self.assertEqual(response.status_code, 404)
+
+    def test_invalid_cover_id(self):
+        project = create_project()
+        requested_url = reverse(
+            'cover-detail',
+            kwargs={'project_id': project.linkname, 'msgid': 'foo'},
+        )
+        response = self.client.get(requested_url)
+        self.assertEqual(response.status_code, 404)
+
 
 class PatchViewTest(TestCase):
 
@@ -121,6 +139,23 @@ class PatchViewTest(TestCase):
         response = self.client.get(requested_url)
         self.assertNotIn('<b>TEST</b>'.encode('utf-8'), response.content)
 
+    def test_invalid_project_id(self):
+        requested_url = reverse(
+            'patch-detail',
+            kwargs={'project_id': 'foo', 'msgid': 'bar'},
+        )
+        response = self.client.get(requested_url)
+        self.assertEqual(response.status_code, 404)
+
+    def test_invalid_patch_id(self):
+        project = create_project()
+        requested_url = reverse(
+            'patch-detail',
+            kwargs={'project_id': project.linkname, 'msgid': 'foo'},
+        )
+        response = self.client.get(requested_url)
+        self.assertEqual(response.status_code, 404)
+
 
 class CommentRedirectTest(TestCase):