From: Dragan Dosen <ddosen@haproxy.com>
Date: Mon, 11 Mar 2024 17:17:26 +0000 (+0100)
Subject: BUG/MINOR: ssl: do not set the aead_tag flags in sample_conv_aes_gcm()
X-Git-Tag: v3.0-dev6~107
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0091692d97407eb96d6cfbb888a254f904182ea9;p=thirdparty%2Fhaproxy.git

BUG/MINOR: ssl: do not set the aead_tag flags in sample_conv_aes_gcm()

This was not useful and was using uninitialized value. Introduced with
the commit 08ac28237 ("MINOR: Add aes_gcm_enc converter").

Must be backported wherever the commit 08ac28237 was backported.
---

diff --git a/src/ssl_sample.c b/src/ssl_sample.c
index abe616025a..99d9dbc250 100644
--- a/src/ssl_sample.c
+++ b/src/ssl_sample.c
@@ -393,7 +393,6 @@ static int sample_conv_aes_gcm(const struct arg *arg_p, struct sample *smp, void
 
 		aead_tag.data.u.str.data = ret;
 		aead_tag.data.type = SMP_T_STR;
-		aead_tag.flags &= ~SMP_F_CONST;
 
 		if (!var_set(arg_p[3].data.var.name_hash, arg_p[3].data.var.scope, &aead_tag,
 		             (arg_p[3].data.var.scope == SCOPE_PROC) ? VF_COND_IFEXISTS : 0)) {