From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Wed, 30 Apr 2025 08:27:42 +0000 (+0300)
Subject: media: i2c: ds90ub960: Fix uninitialized variable in ub960_rxport_bc_ser_config()
X-Git-Tag: v6.16-rc1~145^2~42
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=00cd2d3a1b368685b1302bd45c4783d4c5b907b9;p=thirdparty%2Fkernel%2Flinux.git

media: i2c: ds90ub960: Fix uninitialized variable in ub960_rxport_bc_ser_config()

The "ret" variable is not initialized on success.  Set it to zero.

Fixes: e2a3b695bc5f ("media: i2c: ds90ub960: Configure serializer using back-channel")
Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Jai Luthra <jai.luthra@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
---

diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
index 665efd661882c..ed9ace1a54766 100644
--- a/drivers/media/i2c/ds90ub960.c
+++ b/drivers/media/i2c/ds90ub960.c
@@ -2126,7 +2126,7 @@ static int ub960_rxport_bc_ser_config(struct ub960_rxport *rxport)
 	struct ub960_data *priv = rxport->priv;
 	struct device *dev = &priv->client->dev;
 	u8 nport = rxport->nport;
-	int ret;
+	int ret = 0;
 
 	/* Skip port if serializer's address is not known */
 	if (rxport->ser.addr < 0) {