From: Tim Wiederhake <twiederh@redhat.com>
Date: Tue, 6 Jul 2021 08:23:19 +0000 (+0200)
Subject: virNWFilterDHCPSnoopInit: `virHashNew` cannot return NULL
X-Git-Tag: v7.6.0-rc1~163
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=00d34a085cea57837b82545cd0b801bf70d757bb;p=thirdparty%2Flibvirt.git

virNWFilterDHCPSnoopInit: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/nwfilter/nwfilter_dhcpsnoop.c b/src/nwfilter/nwfilter_dhcpsnoop.c
index 2481ea5371..4b62a7b661 100644
--- a/src/nwfilter/nwfilter_dhcpsnoop.c
+++ b/src/nwfilter/nwfilter_dhcpsnoop.c
@@ -1998,27 +1998,10 @@ virNWFilterDHCPSnoopInit(void)
     virNWFilterSnoopState.snoopReqs =
         virHashNew(virNWFilterSnoopReqRelease);
 
-    if (!virNWFilterSnoopState.ifnameToKey ||
-        !virNWFilterSnoopState.snoopReqs ||
-        !virNWFilterSnoopState.active)
-        goto error;
-
     virNWFilterSnoopLeaseFileLoad();
     virNWFilterSnoopLeaseFileOpen();
 
     return 0;
-
- error:
-    virHashFree(virNWFilterSnoopState.ifnameToKey);
-    virNWFilterSnoopState.ifnameToKey = NULL;
-
-    virHashFree(virNWFilterSnoopState.snoopReqs);
-    virNWFilterSnoopState.snoopReqs = NULL;
-
-    virHashFree(virNWFilterSnoopState.active);
-    virNWFilterSnoopState.active = NULL;
-
-    return -1;
 }
 
 /**