From: Joseph Tam <jtam.home@gmail.com>
Date: Thu, 19 Apr 2012 18:46:16 +0000 (-0700)
Subject: Fix bug #8877 - Syslog broken owing to mistyping of debug_settings.syslog.
X-Git-Tag: samba-4.0.0alpha20~171
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=00d5f32025bf13285ab3f8ffae914107c9eca275;p=thirdparty%2Fsamba.git

Fix bug #8877 - Syslog broken owing to mistyping of debug_settings.syslog.

Setting "syslog only = yes" did not divert log messages to syslog.  The test in
lib/util/debug.c:Debug1():747

   if( syslog_level < state.settings.syslog )

produces wrong results since .syslog is typed "bool" rather than "int".
The attached patch fixes this by typing this field correctly as "int".

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Apr 20 00:06:12 CEST 2012 on sn-devel-104
---

diff --git a/lib/util/debug.h b/lib/util/debug.h
index b3647a33457..256641852bf 100644
--- a/lib/util/debug.h
+++ b/lib/util/debug.h
@@ -201,7 +201,7 @@ enum debug_logtype {DEBUG_DEFAULT_STDERR = 0, DEBUG_DEFAULT_STDOUT = 1, DEBUG_FI
 
 struct debug_settings {
 	size_t max_log_size;
-	bool syslog;
+	int syslog;
 	bool syslog_only;
 	bool timestamp_logs;
 	bool debug_prefix_timestamp;