From: Mae Hood <22501070+biglizards@users.noreply.github.com>
Date: Wed, 30 Apr 2025 23:39:26 +0000 (+0100)
Subject: dict: Remove redundant incref of immortal object Py_EMPTY_KEYS (GH-133200)
X-Git-Tag: v3.14.0b1~156
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=011979132648d50f83d4506d768dca24de47c8c6;p=thirdparty%2FPython%2Fcpython.git

dict: Remove redundant incref of immortal object Py_EMPTY_KEYS (GH-133200)
---

diff --git a/Objects/dictobject.c b/Objects/dictobject.c
index 00658a8ac35b..59b0cf1ce7d4 100644
--- a/Objects/dictobject.c
+++ b/Objects/dictobject.c
@@ -4851,7 +4851,8 @@ dict_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
 
     d->ma_used = 0;
     d->_ma_watcher_tag = 0;
-    dictkeys_incref(Py_EMPTY_KEYS);
+    // We don't inc ref empty keys because they're immortal
+    assert((Py_EMPTY_KEYS)->dk_refcnt == _Py_DICT_IMMORTAL_INITIAL_REFCNT);
     d->ma_keys = Py_EMPTY_KEYS;
     d->ma_values = NULL;
     ASSERT_CONSISTENT(d);