From: lidlanca <lidlanca@yahoo.com>
Date: Thu, 25 Feb 2021 23:25:39 +0000 (-0500)
Subject:  fix(compiler-ssr) ensure that ssrHelpers are unique after merge from parent context... 
X-Git-Tag: v3.0.7~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=012dc5a30366d3325c464c3b62da123147788237;p=thirdparty%2Fvuejs%2Fcore.git

 fix(compiler-ssr) ensure that ssrHelpers are unique after merge from parent context (#3269)

fix #3268
---

diff --git a/packages/compiler-ssr/__tests__/ssrElement.spec.ts b/packages/compiler-ssr/__tests__/ssrElement.spec.ts
index 1d3a2d53d1..796fd41f70 100644
--- a/packages/compiler-ssr/__tests__/ssrElement.spec.ts
+++ b/packages/compiler-ssr/__tests__/ssrElement.spec.ts
@@ -71,6 +71,27 @@ describe('ssr: element', () => {
       `)
     })
 
+    test("multiple _ssrInterpolate at parent and child import dependency once", () => {
+      expect( compile(`<div>{{ hello }}<textarea v-bind="a"></textarea></div>`).code)
+      .toMatchInlineSnapshot(`
+        "const { ssrRenderAttrs: _ssrRenderAttrs, ssrInterpolate: _ssrInterpolate } = require(\\"@vue/server-renderer\\")
+
+        return function ssrRender(_ctx, _push, _parent, _attrs) {
+          let _temp0
+
+          _push(\`<div\${
+            _ssrRenderAttrs(_attrs)
+          }>\${
+            _ssrInterpolate(_ctx.hello)
+          }<textarea\${
+            _ssrRenderAttrs(_temp0 = _ctx.a, \\"textarea\\")
+          }>\${
+            _ssrInterpolate((\\"value\\" in _temp0) ? _temp0.value : \\"\\")
+          }</textarea></div>\`)
+        }"
+      `);
+    });
+
     test('should pass tag to custom elements w/ dynamic v-bind', () => {
       expect(
         compile(`<my-foo v-bind="obj"></my-foo>`, {
diff --git a/packages/compiler-ssr/src/ssrCodegenTransform.ts b/packages/compiler-ssr/src/ssrCodegenTransform.ts
index cebce7433b..7f53ee62c4 100644
--- a/packages/compiler-ssr/src/ssrCodegenTransform.ts
+++ b/packages/compiler-ssr/src/ssrCodegenTransform.ts
@@ -56,10 +56,11 @@ export function ssrCodegenTransform(ast: RootNode, options: CompilerOptions) {
 
   // Finalize helpers.
   // We need to separate helpers imported from 'vue' vs. '@vue/server-renderer'
-  ast.ssrHelpers = [
+  ast.ssrHelpers = Array.from(new Set([  
     ...ast.helpers.filter(h => h in ssrHelpers),
     ...context.helpers
-  ]
+  ]))
+  
   ast.helpers = ast.helpers.filter(h => !(h in ssrHelpers))
 }