From: Eduard Bagdasaryan <eduard.bagdasaryan@measurement-factory.com>
Date: Fri, 13 Aug 2021 17:12:33 +0000 (+0300)
Subject: Excluded Connection::rfc931 from cloning
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=012f5ec;p=thirdparty%2Fsquid.git

Excluded Connection::rfc931 from cloning

This field can be classified as a 'value which cannot be reused across
(co-existing) Connection objects' (since it contains sensitive user
information which should not be leaked to other transactions).
---

diff --git a/src/comm/Connection.cc b/src/comm/Connection.cc
index 2fb964a8ca..279b1c2f4a 100644
--- a/src/comm/Connection.cc
+++ b/src/comm/Connection.cc
@@ -81,8 +81,7 @@ Comm::Connection::cloneProfile() const
     c.nfConnmark = nfConnmark;
     // COMM_ORPHANED is not a part of connection opening instructions
     c.flags = flags & ~COMM_ORPHANED;
-    if (*rfc931) // optimization
-        memcpy(c.rfc931, rfc931, sizeof(rfc931));
+    // rfc931 is excused
 
 #if USE_SQUID_EUI
     // These are currently only set when accepting connections and never used