From: Peter Krempa <pkrempa@redhat.com>
Date: Thu, 8 Dec 2022 10:12:54 +0000 (+0100)
Subject: virStorageBackendISCSIDirectSetAuth: Use 'g_strndup' to '\0' terminate data
X-Git-Tag: v9.1.0-rc1~131
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=014b71a3a775cea54f90f1f45f37d68ed29c6004;p=thirdparty%2Flibvirt.git

virStorageBackendISCSIDirectSetAuth: Use 'g_strndup' to '\0' terminate data

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/storage/storage_backend_iscsi_direct.c b/src/storage/storage_backend_iscsi_direct.c
index 63225c533e..ca906357c3 100644
--- a/src/storage/storage_backend_iscsi_direct.c
+++ b/src/storage/storage_backend_iscsi_direct.c
@@ -117,10 +117,8 @@ virStorageBackendISCSIDirectSetAuth(struct iscsi_context *iscsi,
                                  &secret_value, &secret_size) < 0)
         return -1;
 
-    secret_str = g_new0(char, secret_size + 1);
-    memcpy(secret_str, secret_value, secret_size);
+    secret_str = g_strndup((char *)secret_value, secret_size);
     virSecureErase(secret_value, secret_size);
-    secret_str[secret_size] = '\0';
 
     if (iscsi_set_initiator_username_pwd(iscsi,
                                          authdef->username, secret_str) < 0) {