From: Volker Lendecke <vl@samba.org>
Date: Mon, 10 Feb 2025 08:54:52 +0000 (+0100)
Subject: libsmb: Save lines with a direct variable initialization
X-Git-Tag: tevent-0.17.0~597
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0164041e0192dde7a8a2e4147d72520c7ffb6f52;p=thirdparty%2Fsamba.git

libsmb: Save lines with a direct variable initialization

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/libcli/smb/smbXcli_base.c b/libcli/smb/smbXcli_base.c
index 1e8ccb785de..f61015f84c1 100644
--- a/libcli/smb/smbXcli_base.c
+++ b/libcli/smb/smbXcli_base.c
@@ -1149,18 +1149,14 @@ bool smbXcli_req_set_pending(struct tevent_req *req)
 	struct smbXcli_req_state *state =
 		tevent_req_data(req,
 		struct smbXcli_req_state);
-	struct smbXcli_conn *conn;
-	struct tevent_req **pending;
-	size_t num_pending;
-
-	conn = state->conn;
+	struct smbXcli_conn *conn = state->conn;
+	struct tevent_req **pending = NULL;
+	size_t num_pending = talloc_array_length(conn->pending);
 
 	if (!smbXcli_conn_is_connected(conn)) {
 		return false;
 	}
 
-	num_pending = talloc_array_length(conn->pending);
-
 	pending = talloc_realloc(conn, conn->pending, struct tevent_req *,
 				 num_pending+1);
 	if (pending == NULL) {