From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Thu, 4 Nov 2021 18:59:53 +0000 (-0400)
Subject: Fix various dumb issues
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=016b1bb2ea28d67b65006ddff299af38d24328af;p=thirdparty%2Ffreeradius-server.git

Fix various dumb issues
---

diff --git a/src/lib/unlang/xlat_builtin.c b/src/lib/unlang/xlat_builtin.c
index b8424af418..9564f32724 100644
--- a/src/lib/unlang/xlat_builtin.c
+++ b/src/lib/unlang/xlat_builtin.c
@@ -627,7 +627,7 @@ static xlat_action_t xlat_load_balance(TALLOC_CTX *ctx, fr_dcursor_t *out,
 		 *	cost.
 		 */
 		xlat = xlat_func_find(name, -1);
-		if (!xlat) return -1;
+		if (!xlat) return XLAT_ACTION_FAIL;
 
 		return xlat->func.async(ctx, out, request, xlat->mod_inst, xlat->thread_uctx, in);
 	}
@@ -713,6 +713,8 @@ int xlat_register_redundant(CONF_SECTION *cs)
 
 	} else {
 		fr_assert(0);
+		cf_log_err(cs, "Invalid redundant section verb");
+		return -1;
 	}
 
 	xr->cs = cs;
diff --git a/src/modules/rlm_test/rlm_test.c b/src/modules/rlm_test/rlm_test.c
index c4f6841d1a..1d8d39e4ab 100644
--- a/src/modules/rlm_test/rlm_test.c
+++ b/src/modules/rlm_test/rlm_test.c
@@ -439,7 +439,7 @@ static int mod_thread_detach(UNUSED fr_event_list_t *el, void *thread)
  *	that must be referenced in later calls, store a handle to it
  *	in *instance otherwise put a null pointer there.
  */
-static int mod_bootstrap(void *instance, UNUSED CONF_SECTION *conf)
+static int mod_bootstrap(void *instance, CONF_SECTION *conf)
 {
 	xlat_t *xlat;
 	rlm_test_t *inst = instance;