From: Viktor Szakats Date: Sun, 5 Mar 2023 19:51:52 +0000 (+0000) Subject: cmake: skip CA-path/bundle auto-detection in cross-builds X-Git-Tag: curl-8_0_0~104 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=016c62c4d52997f31d7e45b50cc7e8165a1488dc;p=thirdparty%2Fcurl.git cmake: skip CA-path/bundle auto-detection in cross-builds Also remove issue from KNOWN_BUGS. Reported-by: Cristian Morales Vega Reviewed-by: Marcel Raad Fixes #6178 Closes #10676 --- diff --git a/CMakeLists.txt b/CMakeLists.txt index b97704bfef..be0e5f8d7c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -870,7 +870,9 @@ elseif("${CURL_CA_BUNDLE}" STREQUAL "none") unset(CURL_CA_BUNDLE CACHE) elseif("${CURL_CA_BUNDLE}" STREQUAL "auto") unset(CURL_CA_BUNDLE CACHE) - set(CURL_CA_BUNDLE_AUTODETECT TRUE) + if(NOT CMAKE_CROSSCOMPILING) + set(CURL_CA_BUNDLE_AUTODETECT TRUE) + endif() else() set(CURL_CA_BUNDLE_SET TRUE) endif() @@ -881,7 +883,7 @@ elseif("${CURL_CA_PATH}" STREQUAL "none") unset(CURL_CA_PATH CACHE) elseif("${CURL_CA_PATH}" STREQUAL "auto") unset(CURL_CA_PATH CACHE) - if(NOT USE_NSS) + if(NOT CMAKE_CROSSCOMPILING AND NOT USE_NSS) set(CURL_CA_PATH_AUTODETECT TRUE) endif() else() diff --git a/docs/KNOWN_BUGS b/docs/KNOWN_BUGS index 7b19b82ac5..3b35ad9a66 100644 --- a/docs/KNOWN_BUGS +++ b/docs/KNOWN_BUGS @@ -107,7 +107,6 @@ problems may have been fixed or changed somewhat since this was written. 15.6 uses -lpthread instead of Threads::Threads 15.7 generated .pc file contains strange entries 15.8 libcurl.pc uses absolute library paths - 15.9 cert paths autodetected when cross-compiling 15.10 libpsl is not supported 15.11 ExternalProject_Add does not set CURL_CA_PATH 15.12 cannot enable LDAPS on Windows @@ -684,13 +683,6 @@ problems may have been fixed or changed somewhat since this was written. See https://github.com/curl/curl/issues/6169 -15.9 cert paths autodetected when cross-compiling - - The autotools build disables the ca_path/ca_bundle detection when - cross-compiling. The cmake build keeps doing the detection. - - See https://github.com/curl/curl/issues/6178 - 15.10 libpsl is not supported See https://github.com/curl/curl/issues/6214