From: Naoki Kambe <kambe@jprs.co.jp>
Date: Mon, 11 Mar 2013 12:09:23 +0000 (+0900)
Subject: [2252] simplify complicated if-else lines (unrelated to #2252)
X-Git-Tag: bind10-1.2.0beta1-release~474^2~4^2~72
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=01b2a2fa9d86fbc5796626461b282581e46d2979;p=thirdparty%2Fkea.git

[2252] simplify complicated if-else lines (unrelated to #2252)
---

diff --git a/src/bin/xfrin/xfrin.py.in b/src/bin/xfrin/xfrin.py.in
index 775d8621c6..2f9fccb4d8 100755
--- a/src/bin/xfrin/xfrin.py.in
+++ b/src/bin/xfrin/xfrin.py.in
@@ -1032,14 +1032,10 @@ class XfrinConnection(asyncore.dispatcher):
             # (if not yet - possible in case of xfr-level exception) as soon
             # as possible
             self._diff = None
-            if ret == XFRIN_OK:
-                # count successful xfer requests
+            counter_dict = {XFRIN_OK: 'xfrsuccess', XFRIN_FAIL: 'xfrfail'}
+            if ret in counter_dict:
                 self._counters.inc('zones', self._zone_name.to_text(),
-                                   'xfrsuccess')
-            elif ret == XFRIN_FAIL:
-                # count failed xfer requests
-                self._counters.inc('zones', self._zone_name.to_text(),
-                                   'xfrfail')
+                                   counter_dict[ret])
 
         return ret