From: Yehor Velykozhon -X (yvelykoz - SOFTSERVE INC at Cisco) <yvelykoz@cisco.com>
Date: Thu, 13 Feb 2025 09:31:49 +0000 (+0000)
Subject: Pull request #4615: SSE: deletion of continuations
X-Git-Tag: 3.7.1.0~27
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=01b61819cf3af7ed2e69346eb6f8941aa0438054;p=thirdparty%2Fsnort3.git

Pull request #4615: SSE: deletion of continuations

Merge in SNORT/snort3 from ~YVELYKOZ/snort3:sse_recall_old_cont_on_limit to master

Squashed commit of the following:

commit fad4d37f74ab9445fc00aab2a72bf84eed8532e7
Author: Yehor Velykozhon <yvelykoz@cisco.com>
Date:   Thu Feb 6 17:13:32 2025 +0200

    detection: fix leave_group call which should be against current packet only
---

diff --git a/src/detection/detection_continuation.h b/src/detection/detection_continuation.h
index acfd7a940..d64775fa3 100644
--- a/src/detection/detection_continuation.h
+++ b/src/detection/detection_continuation.h
@@ -188,8 +188,9 @@ void Continuation::eval(snort::Packet& p)
         {
             assert(0 < states_cnt);
             assert(st != &states);
+            assert((**st).packet_number != p.context->packet_number);
+
             --states_cnt;
-            st->leave_group();
             delete st;
         }
     }