From: Luca Di Maio <luca.dimaio1@gmail.com>
Date: Fri, 24 Oct 2025 19:36:48 +0000 (+0200)
Subject: proto: fix file descriptor leak
X-Git-Tag: v6.18.0~81
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=01c46f93ffcd2ed50e82f967ec497b1ad542f89a;p=thirdparty%2Fxfsprogs-dev.git

proto: fix file descriptor leak

fix leak of pathfd introduced in commit 8a4ea72724930cfe262ccda03028264e1a81b145

Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Fixes: 8a4ea72724930c ("proto: add ability to populate a filesystem from a directory")
---

diff --git a/mkfs/proto.c b/mkfs/proto.c
index 2b29240d..1a7b3586 100644
--- a/mkfs/proto.c
+++ b/mkfs/proto.c
@@ -1772,6 +1772,7 @@ handle_direntry(
 	create_nondir_inode(mp, pip, fsxp, mode, creds, xname, flags, file_stat,
 			    rdev, fd, fname);
 out:
+	close(pathfd);
 	/* Reset path_buf to original */
 	path_buf[path_len] = '\0';
 }