From: mkanat%bugzilla.org <>
Date: Wed, 19 Dec 2007 06:43:18 +0000 (+0000)
Subject: Bug 408766: Apache::DBI is a premature optimization that causes trouble
X-Git-Tag: bugzilla-3.0.3~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=01c9621b5db0e0e348d12083091bcdda25309272;p=thirdparty%2Fbugzilla.git

Bug 408766: Apache::DBI is a premature optimization that causes trouble
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=justdave, a=mkanat
---

diff --git a/Bugzilla/DB.pm b/Bugzilla/DB.pm
index b4f6596852..7a19f8fd42 100644
--- a/Bugzilla/DB.pm
+++ b/Bugzilla/DB.pm
@@ -898,7 +898,6 @@ sub db_new {
                   } if (!defined($attributes));
 
     # connect using our known info to the specified db
-    # Apache::DBI will cache this when using mod_perl
     my $self = DBI->connect($dsn, $user, $pass, $attributes)
         or die "\nCan't connect to the database.\nError: $DBI::errstr\n"
         . "  Is your database installed and up and running?\n  Do you have"
diff --git a/Bugzilla/Install/Requirements.pm b/Bugzilla/Install/Requirements.pm
index 430df7284a..899821cd4c 100644
--- a/Bugzilla/Install/Requirements.pm
+++ b/Bugzilla/Install/Requirements.pm
@@ -221,12 +221,6 @@ sub OPTIONAL_MODULES {
         version => '3.11',
         feature => 'mod_perl'
     },
-    {
-        package => 'Apache-DBI',
-        module  => 'Apache::DBI',
-        version => '0.96',
-        feature => 'mod_perl'
-    },
     );
 
     my $all_modules = _get_extension_requirements(
diff --git a/docs/xml/installation.xml b/docs/xml/installation.xml
index 6a43f29718..0591bab0b5 100644
--- a/docs/xml/installation.xml
+++ b/docs/xml/installation.xml
@@ -1,5 +1,5 @@
 <!-- <!DOCTYPE chapter PUBLIC "-//OASIS//DTD DocBook XML V4.1.2//EN"> -->
-<!-- $Id: installation.xml,v 1.136.2.6 2007/10/16 09:57:01 justdave%bugzilla.org Exp $ -->
+<!-- $Id: installation.xml,v 1.136.2.7 2007/12/19 00:43:20 mkanat%bugzilla.org Exp $ -->
 <chapter id="installing-bugzilla">
   <title>Installing Bugzilla</title>
 
@@ -468,12 +468,6 @@
           </para>
         </listitem>
 
-        <listitem>
-          <para>
-            Apache::DBI
-            (&min-apache-dbi-ver;) for mod_perl2
-          </para>
-        </listitem>
       </orderedlist>
       </para>
 
@@ -650,9 +644,6 @@
       <para>Bugzilla also requires a more up-to-date version of the CGI
       perl module to be installed, version &min-mp-cgi-ver; as opposed to &min-cgi-ver;
       </para>
-      
-      <para>Finally, Bugzilla also requires <literal>Apache::DBI</literal>
-      (&min-apache-dbi-ver;) to be installed as well.</para>
     </section>
   </section>
   
diff --git a/mod_perl.pl b/mod_perl.pl
index 36912c68cf..bd6ef1002e 100644
--- a/mod_perl.pl
+++ b/mod_perl.pl
@@ -28,7 +28,6 @@ use strict;
 # startup, so we always specify () after using any module in this
 # file.
 
-use Apache::DBI ();
 use Apache2::ServerUtil;
 use Apache2::SizeLimit;
 use ModPerl::RegistryLoader ();