From: Evan You <evan@vuejs.org>
Date: Sat, 1 Feb 2025 13:07:06 +0000 (+0800)
Subject: chore(lint): allow DOM globals in runtime-vapor
X-Git-Tag: v3.6.0-alpha.1~16^2~110
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=01d6aa0d33aa34c575728128eb48b09e45088bff;p=thirdparty%2Fvuejs%2Fcore.git

chore(lint): allow DOM globals in runtime-vapor
---

diff --git a/eslint.config.js b/eslint.config.js
index 7282992910..64d57dfc39 100644
--- a/eslint.config.js
+++ b/eslint.config.js
@@ -106,7 +106,7 @@ export default tseslint.config(
 
   // Packages targeting DOM
   {
-    files: ['packages/{vue,vue-compat,runtime-dom}/**'],
+    files: ['packages/{vue,vue-compat,runtime-dom,runtime-vapor}/**'],
     rules: {
       'no-restricted-globals': ['error', ...NodeGlobals],
     },
diff --git a/packages/runtime-vapor/src/block.ts b/packages/runtime-vapor/src/block.ts
index bd16012700..df14aeb316 100644
--- a/packages/runtime-vapor/src/block.ts
+++ b/packages/runtime-vapor/src/block.ts
@@ -37,8 +37,7 @@ export class DynamicFragment extends Fragment {
     this.anchor =
       __DEV__ && anchorLabel
         ? createComment(anchorLabel)
-        : // eslint-disable-next-line no-restricted-globals
-          document.createTextNode('')
+        : document.createTextNode('')
   }
 
   update(render?: BlockFn, key: any = render): void {
diff --git a/packages/runtime-vapor/src/component.ts b/packages/runtime-vapor/src/component.ts
index ee56aa9cda..58341312fc 100644
--- a/packages/runtime-vapor/src/component.ts
+++ b/packages/runtime-vapor/src/component.ts
@@ -452,7 +452,6 @@ export function createComponentWithFallback(
     return createComponent(comp, rawProps, rawSlots, isSingleRoot)
   }
 
-  // eslint-disable-next-line no-restricted-globals
   const el = document.createElement(comp)
   // mark single root
   ;(el as any).$root = isSingleRoot
diff --git a/packages/runtime-vapor/src/dom/event.ts b/packages/runtime-vapor/src/dom/event.ts
index b27cbf5625..4f7b516f15 100644
--- a/packages/runtime-vapor/src/dom/event.ts
+++ b/packages/runtime-vapor/src/dom/event.ts
@@ -76,7 +76,6 @@ export const delegateEvents = (...names: string[]): void => {
   for (const name of names) {
     if (!delegatedEvents[name]) {
       delegatedEvents[name] = true
-      // eslint-disable-next-line no-restricted-globals
       document.addEventListener(name, delegatedEventHandler)
     }
   }
@@ -93,7 +92,6 @@ const delegatedEventHandler = (e: Event) => {
   Object.defineProperty(e, 'currentTarget', {
     configurable: true,
     get() {
-      // eslint-disable-next-line no-restricted-globals
       return node || document
     },
   })
diff --git a/packages/runtime-vapor/src/dom/node.ts b/packages/runtime-vapor/src/dom/node.ts
index 5a50cd0aa1..f80b9ea676 100644
--- a/packages/runtime-vapor/src/dom/node.ts
+++ b/packages/runtime-vapor/src/dom/node.ts
@@ -3,7 +3,6 @@ import { renderEffect } from '../renderEffect'
 import { setText } from './prop'
 
 export function createTextNode(values?: any[] | (() => any[])): Text {
-  // eslint-disable-next-line no-restricted-globals
   const node = document.createTextNode('')
   if (values) {
     if (isArray(values)) {
@@ -17,12 +16,10 @@ export function createTextNode(values?: any[] | (() => any[])): Text {
 
 /*! #__NO_SIDE_EFFECTS__ */
 export function createComment(data: string): Comment {
-  // eslint-disable-next-line no-restricted-globals
   return document.createComment(data)
 }
 
 /*! #__NO_SIDE_EFFECTS__ */
 export function querySelector(selectors: string): Element | null {
-  // eslint-disable-next-line no-restricted-globals
   return document.querySelector(selectors)
 }
diff --git a/packages/runtime-vapor/src/dom/template.ts b/packages/runtime-vapor/src/dom/template.ts
index d321685f31..353ed7e363 100644
--- a/packages/runtime-vapor/src/dom/template.ts
+++ b/packages/runtime-vapor/src/dom/template.ts
@@ -2,7 +2,6 @@
 export function template(html: string, root?: boolean) {
   let node: ChildNode
   const create = () => {
-    // eslint-disable-next-line no-restricted-globals
     const t = document.createElement('template')
     t.innerHTML = html
     return t.content.firstChild!