From: Alan T. DeKok <aland@freeradius.org>
Date: Sun, 17 Sep 2023 13:57:38 +0000 (-0400)
Subject: remove assertion
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=01ee2223c1f8676b7ed60d522a41a9ab6d75c60e;p=thirdparty%2Ffreeradius-server.git

remove assertion

memdup_shallow() is sometimes called with non-talloc'd memory

in some cases the calls are wrong, and this causes a later assert
in the verify functions.  In other cases, the calls are correct.
---

diff --git a/src/lib/util/value.c b/src/lib/util/value.c
index 175d1dae639..5ff79618dfd 100644
--- a/src/lib/util/value.c
+++ b/src/lib/util/value.c
@@ -4366,7 +4366,6 @@ void fr_value_box_memdup_shallow(fr_value_box_t *dst, fr_dict_attr_t const *enum
 				 uint8_t const *src, size_t len, bool tainted)
 {
 	fr_value_box_init(dst, FR_TYPE_OCTETS, enumv, tainted);
-	(void) talloc_get_name(src);
 	dst->vb_octets = src;
 	dst->vb_length = len;
 }