From: Pauli <pauli@openssl.org>
Date: Mon, 28 Jun 2021 21:59:00 +0000 (+1000)
Subject: test: fix coverity 1469427 Improper use of negative value (NEGATIVE_RETURNS)
X-Git-Tag: openssl-3.0.0-beta2~152
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=01fb4bff9bee4b6a652d42ec9f1b677773280450;p=thirdparty%2Fopenssl.git

test: fix coverity 1469427 Improper use of negative value (NEGATIVE_RETURNS)

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/15943)
---

diff --git a/test/endecoder_legacy_test.c b/test/endecoder_legacy_test.c
index 121e2de3d4e..943cba56e59 100644
--- a/test/endecoder_legacy_test.c
+++ b/test/endecoder_legacy_test.c
@@ -289,7 +289,8 @@ static int test_membio_str_eq(BIO *bio_provided, BIO *bio_legacy)
     long len_provided = BIO_get_mem_data(bio_provided, &str_provided);
     long len_legacy = BIO_get_mem_data(bio_legacy, &str_legacy);
 
-    return TEST_long_ge(len_provided, 0)
+    return TEST_long_ge(len_legacy, 0)
+           && TEST_long_ge(len_provided, 0)
            && TEST_strn2_eq(str_provided, len_provided,
                             str_legacy, len_legacy);
 }