From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Tue, 19 Jan 2021 14:30:20 +0000 (+0000)
Subject: We produce asserts on bad arguments
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=020033e727083a67b5d9d62befabc7fd3ade86ef;p=thirdparty%2Ffreeradius-server.git

We produce asserts on bad arguments
---

diff --git a/src/lib/unlang/xlat_eval.c b/src/lib/unlang/xlat_eval.c
index ecc90286126..89d20a60f2a 100644
--- a/src/lib/unlang/xlat_eval.c
+++ b/src/lib/unlang/xlat_eval.c
@@ -566,16 +566,7 @@ static xlat_action_t xlat_eval_pair_real(TALLOC_CTX *ctx, fr_cursor_t *out, requ
 
 	xlat_action_t		ret = XLAT_ACTION_DONE;
 
-	if (!tmpl_is_attr(vpt) && !tmpl_is_list(vpt)) {
-		if (tmpl_is_attr_unresolved(vpt)) {
-			REDEBUG("Unknown attribute '%s'", vpt->name);
-			return XLAT_ACTION_FAIL;
-		}
-
-		REDEBUG("Invalid expansion type %s",
-			fr_table_str_by_value(tmpl_type_table, vpt->type, "<INVALID>"));
-		return XLAT_ACTION_FAIL;
-	}
+	fr_assert(tmpl_is_attr(vpt) || tmpl_is_list(vpt));
 
 	/*
 	 *	See if we're dealing with an attribute in the request