From: Phil Sutter <phil@nwl.cc>
Date: Fri, 17 May 2024 13:20:05 +0000 (+0200)
Subject: extensions: libxt_sctp: Add an extra assert()
X-Git-Tag: v1.8.11~59
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0234117d24609070f08ef36a11795c3c8e4c19bf;p=thirdparty%2Fiptables.git

extensions: libxt_sctp: Add an extra assert()

The code is sane, but this keeps popping up in static code analyzers.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/extensions/libxt_sctp.c b/extensions/libxt_sctp.c
index 6e2b2745..e8312f0c 100644
--- a/extensions/libxt_sctp.c
+++ b/extensions/libxt_sctp.c
@@ -7,6 +7,7 @@
  * libipt_ecn.c borrowed heavily from libipt_dscp.c
  *
  */
+#include <assert.h>
 #include <stdbool.h>
 #include <stdio.h>
 #include <string.h>
@@ -354,6 +355,7 @@ print_chunk_flags(uint32_t chunknum, uint8_t chunk_flags, uint8_t chunk_flags_ma
 
 	for (i = 7; i >= 0; i--) {
 		if (chunk_flags_mask & (1 << i)) {
+			assert(chunknum < ARRAY_SIZE(sctp_chunk_names));
 			if (chunk_flags & (1 << i)) {
 				printf("%c", sctp_chunk_names[chunknum].valid_flags[7-i]);
 			} else {