From: Luke Howard <lukeh@padl.com>
Date: Sun, 30 Aug 2009 18:14:01 +0000 (+0000)
Subject: cleanup
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0249d1338a9e06ac53db4c1dbbfe8635874cbbf2;p=thirdparty%2Fkrb5.git

cleanup

git-svn-id: svn://anonsvn.mit.edu/krb5/users/lhoward/authdata@22667 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/plugins/authdata/greet_server/greet_auth.c b/src/plugins/authdata/greet_server/greet_auth.c
index 7f89e3469e..f732e9d647 100644
--- a/src/plugins/authdata/greet_server/greet_auth.c
+++ b/src/plugins/authdata/greet_server/greet_auth.c
@@ -84,11 +84,14 @@ greet_kdc_verify(krb5_context context,
         return code;
     }
 
+#ifdef TEST_ISSUER
     if (issuer == NULL ||
         !krb5_principal_compare(context, issuer, greet_issuer)) {
+        krb5_free_principal(context, issuer);
         krb5_free_authdata(context, kdc_issued);
         return KRB5KDC_ERR_CLIENT_NOT_TRUSTED;
     }
+#endif
 
     code = krb5int_find_authdata(context,
                                  kdc_issued,
@@ -108,6 +111,7 @@ greet_kdc_verify(krb5_context context,
     krb5_free_authdata(context, tgt_authdata);
     krb5_free_authdata(context, kdc_issued);
     krb5_free_authdata(context, greet);
+    krb5_free_principal(context, issuer);
 
     return code;
 }
@@ -171,12 +175,14 @@ greet_authdata(krb5_context context,
 {
     krb5_error_code code;
     krb5_boolean tgs_req = (request->msg_type == KRB5_TGS_REQ);
-    krb5_principal issuer = NULL;
     krb5_data *greeting = NULL;
+    krb5_principal issuer = NULL;
 
+#ifdef TEST_ISSUER
     code = krb5_parse_name(context, "greet@", &issuer);
     if (code != 0)
         return code;
+#endif
 
     if (tgs_req)
         code = greet_kdc_verify(context, enc_tkt_request, issuer, &greeting);
@@ -188,6 +194,7 @@ greet_authdata(krb5_context context,
 
     code = greet_kdc_sign(context, enc_tkt_reply, issuer, greeting);
 
+    krb5_free_principal(context, issuer);
     krb5_free_data(context, greeting);
 
     return code;