From: Volker Lendecke <vl@samba.org>
Date: Sun, 18 Aug 2013 20:41:51 +0000 (+0000)
Subject: rpc_server: Fix CID 1063255 Resource leak
X-Git-Tag: talloc-2.1.0~135
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=02618cc58a49864bd0bf280d9f13a7f39fcf9658;p=thirdparty%2Fsamba.git

rpc_server: Fix CID 1063255 Resource leak

We would leak a socket 0 here

Signed-off-by: Volker Lendecke <vl@samba.org>

Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Aug 19 03:10:51 CEST 2013 on sn-devel-104
---

diff --git a/source3/rpc_server/rpc_server.c b/source3/rpc_server/rpc_server.c
index de54ddc6e28..fa3c8709fa3 100644
--- a/source3/rpc_server/rpc_server.c
+++ b/source3/rpc_server/rpc_server.c
@@ -620,7 +620,7 @@ int create_tcpip_socket(const struct sockaddr_storage *ifss, uint16_t *port)
 					    0,
 					    ifss,
 					    false);
-			if (fd > 0) {
+			if (fd >= 0) {
 				*port = i;
 				break;
 			}