From: Tobias Burnus <tobias@codesourcery.com>
Date: Wed, 17 Aug 2022 13:52:23 +0000 (+0200)
Subject: OpenMP requires: Fix diagnostic filename corner case
X-Git-Tag: basepoints/gcc-14~5115
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=027b281f1e8de55d959695c7f1e80572fae6dbe7;p=thirdparty%2Fgcc.git

OpenMP requires: Fix diagnostic filename corner case

The issue occurs when there is, e.g., main._omp_fn.0 in two files with
different OpenMP requires clauses.  The function entries in the offload
table ends up having the same decl tree and, hence, the diagnostic showed
the same filename for both.  Solution: Use the .o filename in this case.

Note that the issue does not occur with same-named 'static' functions and
without the fatal error from the requires diagnostic, there would be
later a linker error due to having two 'main'.

gcc/
	* lto-cgraph.cc (input_offload_tables): Improve requires diagnostic
	when filenames come out identically.
---

diff --git a/gcc/lto-cgraph.cc b/gcc/lto-cgraph.cc
index 6d9c36ea8b6..39af9c1bd07 100644
--- a/gcc/lto-cgraph.cc
+++ b/gcc/lto-cgraph.cc
@@ -1881,6 +1881,11 @@ input_offload_tables (bool do_force_output)
 		      if (tmp_decl != NULL_TREE)
 			fn2 = IDENTIFIER_POINTER (DECL_NAME (tmp_decl));
 		    }
+		  if (fn1 == fn2)
+		    {
+		      fn1 = requires_fn;
+		      fn2 = file_data->file_name;
+		    }
 
 		  char buf1[sizeof ("unified_address, unified_shared_memory, "
 				    "reverse_offload")];