From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 23 May 2025 12:10:50 +0000 (+0200)
Subject: machined: properly open up all missing method calls via D-Bus to unpriv clients
X-Git-Tag: v258-rc1~360
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=02927af799dbca2ca22a652dc9acc692326dbc3f;p=thirdparty%2Fsystemd.git

machined: properly open up all missing method calls via D-Bus to unpriv clients

These method calls all already have polkit hookup, hence actually allow
them to go through on all levels.

This is mostly playing catchup with a variety of calls added over the
years.
---

diff --git a/src/machine/org.freedesktop.machine1.conf b/src/machine/org.freedesktop.machine1.conf
index c3c8149f9ab..c0b329fcc3b 100644
--- a/src/machine/org.freedesktop.machine1.conf
+++ b/src/machine/org.freedesktop.machine1.conf
@@ -60,6 +60,10 @@
                        send_interface="org.freedesktop.machine1.Manager"
                        send_member="GetMachineAddresses"/>
 
+                <allow send_destination="org.freedesktop.machine1"
+                       send_interface="org.freedesktop.machine1.Manager"
+                       send_member="GetMachineSSHInfo"/>
+
                 <allow send_destination="org.freedesktop.machine1"
                        send_interface="org.freedesktop.machine1.Manager"
                        send_member="GetMachineOSRelease"/>
@@ -80,6 +84,10 @@
                        send_interface="org.freedesktop.machine1.Manager"
                        send_member="OpenMachineShell"/>
 
+                <allow send_destination="org.freedesktop.machine1"
+                       send_interface="org.freedesktop.machine1.Manager"
+                       send_member="OpenMachineRootDirectory"/>
+
                 <allow send_destination="org.freedesktop.machine1"
                        send_interface="org.freedesktop.machine1.Manager"
                        send_member="UnregisterMachine"/>
@@ -100,10 +108,18 @@
                        send_interface="org.freedesktop.machine1.Manager"
                        send_member="CopyFromMachine"/>
 
+                <allow send_destination="org.freedesktop.machine1"
+                       send_interface="org.freedesktop.machine1.Manager"
+                       send_member="CopyFromMachineWithFlags"/>
+
                 <allow send_destination="org.freedesktop.machine1"
                        send_interface="org.freedesktop.machine1.Manager"
                        send_member="CopyToMachine"/>
 
+                <allow send_destination="org.freedesktop.machine1"
+                       send_interface="org.freedesktop.machine1.Manager"
+                       send_member="CopyToMachineWithFlags"/>
+
                 <allow send_destination="org.freedesktop.machine1"
                        send_interface="org.freedesktop.machine1.Manager"
                        send_member="RemoveImage"/>
@@ -168,6 +184,10 @@
                        send_interface="org.freedesktop.machine1.Machine"
                        send_member="GetAddresses"/>
 
+                <allow send_destination="org.freedesktop.machine1"
+                       send_interface="org.freedesktop.machine1.Machine"
+                       send_member="GetSSHInfo"/>
+
                 <allow send_destination="org.freedesktop.machine1"
                        send_interface="org.freedesktop.machine1.Machine"
                        send_member="GetOSRelease"/>
@@ -188,6 +208,10 @@
                        send_interface="org.freedesktop.machine1.Machine"
                        send_member="OpenShell"/>
 
+                <allow send_destination="org.freedesktop.machine1"
+                       send_interface="org.freedesktop.machine1.Machine"
+                       send_member="OpenRootDirectory"/>
+
                 <allow send_destination="org.freedesktop.machine1"
                        send_interface="org.freedesktop.machine1.Machine"
                        send_member="Terminate"/>
@@ -204,10 +228,20 @@
                        send_interface="org.freedesktop.machine1.Machine"
                        send_member="CopyFrom"/>
 
+                <allow send_destination="org.freedesktop.machine1"
+                       send_interface="org.freedesktop.machine1.Machine"
+                       send_member="CopyFromWithFlags"/>
+
                 <allow send_destination="org.freedesktop.machine1"
                        send_interface="org.freedesktop.machine1.Machine"
                        send_member="CopyTo"/>
 
+                <allow send_destination="org.freedesktop.machine1"
+                       send_interface="org.freedesktop.machine1.Machine"
+                       send_member="CopyToWithFlags"/>
+
+                <!-- org.freedesktop.machine1.Image Method Calls -->
+
                 <allow send_destination="org.freedesktop.machine1"
                        send_interface="org.freedesktop.machine1.Image"
                        send_member="Remove"/>