From: Pavel Filipenský Date: Mon, 23 May 2022 11:10:31 +0000 (+0200) Subject: python/gp_cert_auto_enroll: Fix bitwise test in expression X-Git-Tag: talloc-2.3.4~83 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=02a9a160e2d6d14b6dc04dcda1a136484f5edd95;p=thirdparty%2Fsamba.git python/gp_cert_auto_enroll: Fix bitwise test in expression Found by covscan. result_independent_of_operands: "(e.data & 4) == 1" is always false regardless of the values of its operands. This occurs as the operand of assignment. Signed-off-by: Pavel Filipenský Reviewed-by: Andreas Schneider Reviewed-by: Jeremy Allison --- diff --git a/python/samba/gp_cert_auto_enroll_ext.py b/python/samba/gp_cert_auto_enroll_ext.py index 680525c9ced..585dc560550 100644 --- a/python/samba/gp_cert_auto_enroll_ext.py +++ b/python/samba/gp_cert_auto_enroll_ext.py @@ -358,9 +358,9 @@ class gp_cert_auto_enroll_ext(gp_pol_ext): # This policy applies as specified in [MS-CAESO] 4.4.5.1 if e.data == 0x8000: continue # The policy is disabled - enroll = e.data & 0x1 == 1 - manage = e.data & 0x2 == 1 - retrive_pending = e.data & 0x4 == 1 + enroll = e.data & 0x1 == 0x1 + manage = e.data & 0x2 == 0x2 + retrive_pending = e.data & 0x4 == 0x4 if enroll: self.__enroll(pol_conf.entries, trust_dir, private_dir)