From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Tue, 13 Oct 2020 13:14:31 +0000 (-0500)
Subject: Give in to static analysis stupidity
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=02ca1925b92db2f7f1ec18eec341c16cb42f8563;p=thirdparty%2Ffreeradius-server.git

Give in to static analysis stupidity
---

diff --git a/src/lib/unlang/compile.c b/src/lib/unlang/compile.c
index 0dffd74df1f..f9e0c2c05ba 100644
--- a/src/lib/unlang/compile.c
+++ b/src/lib/unlang/compile.c
@@ -1186,7 +1186,7 @@ static int compile_map_name(unlang_group_t *g)
 	 *	name1 and name2, they form input
 	 *	arguments into the map.
 	 */
-	if (cf_section_argv(g->cs, 0)) {
+	if (kctx->vpt) {
 		char	quote;
 		size_t	quoted_len;
 		char	*quoted_str;
@@ -1209,8 +1209,6 @@ static int compile_map_name(unlang_group_t *g)
 			break;
 		}
 
-		fr_assert(kctx->vpt != NULL);
-		fr_assert(kctx->vpt->name != NULL);
 		quoted_len = fr_snprint_len(kctx->vpt->name, kctx->vpt->len, quote);
 		quoted_str = talloc_array(g, char, quoted_len);
 		fr_snprint(quoted_str, quoted_len, kctx->vpt->name, kctx->vpt->len, quote);