From: Al Viro <viro@zeniv.linux.org.uk>
Date: Thu, 9 May 2024 03:21:06 +0000 (-0400)
Subject: binderfs_binder_ctl_create(): kill a bogus check
X-Git-Tag: v6.19-rc1~111^2~26
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=02da8d2c0965fe9183b6100e438a3aee8bc4e088;p=thirdparty%2Fkernel%2Flinux.git

binderfs_binder_ctl_create(): kill a bogus check

It's called once, during binderfs mount, right after allocating
root dentry.  Checking that it hadn't been already called is
only obfuscating things.

Looks like that bogosity had been copied from devpts...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
index a7b0a773d47f5..8253e517ab6c6 100644
--- a/drivers/android/binderfs.c
+++ b/drivers/android/binderfs.c
@@ -397,12 +397,6 @@ static int binderfs_binder_ctl_create(struct super_block *sb)
 	if (!device)
 		return -ENOMEM;
 
-	/* If we have already created a binder-control node, return. */
-	if (info->control_dentry) {
-		ret = 0;
-		goto out;
-	}
-
 	ret = -ENOMEM;
 	inode = new_inode(sb);
 	if (!inode)