From: Jim Meyering <jim@meyering.net>
Date: Tue, 18 Nov 2003 16:17:00 +0000 (+0000)
Subject: `od -c -w9999999' could segfault
X-Git-Tag: v5.1.0~150
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=02fbbc8ea26882d6ae46099cb8fc7fee73efb25e;p=thirdparty%2Fcoreutils.git

`od -c -w9999999' could segfault

(dump): Use xnmalloc/free, not alloca.
---

diff --git a/src/od.c b/src/od.c
index c68d40baca..5dd9d9f4d6 100644
--- a/src/od.c
+++ b/src/od.c
@@ -1421,8 +1421,8 @@ dump (void)
   int err;
   size_t n_bytes_read;
 
-  block[0] = alloca (bytes_per_block);
-  block[1] = alloca (bytes_per_block);
+  block[0] = xnmalloc (2, bytes_per_block);
+  block[1] = block[0] + bytes_per_block;
 
   current_offset = n_bytes_to_skip;
 
@@ -1487,6 +1487,8 @@ dump (void)
   if (limit_bytes_to_format && current_offset >= end_offset)
     err |= check_and_close (0);
 
+  free (block[0]);
+
   return err;
 }