From: Nick Porter <nick@portercomputing.co.uk>
Date: Mon, 10 Jun 2024 07:40:28 +0000 (+0100)
Subject: Satisfy both clang scan and Coverity (CID #1603335)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=02fdbaeae72cf342fb412c072ded6ac2addb138b;p=thirdparty%2Ffreeradius-server.git

Satisfy both clang scan and Coverity (CID #1603335)
---

diff --git a/src/modules/rlm_sql/rlm_sql.c b/src/modules/rlm_sql/rlm_sql.c
index d5e171a2308..03ab4ab92fd 100644
--- a/src/modules/rlm_sql/rlm_sql.c
+++ b/src/modules/rlm_sql/rlm_sql.c
@@ -987,7 +987,7 @@ static unlang_action_t sql_get_grouplist_resume(rlm_rcode_t *p_result, UNUSED in
 			goto error;
 		}
 
-		if (!group_ctx->groups || !entry) {	/* clang scan couldn't tell that when groups_ctx->groups != NULL then entry != NULL */
+		if (!entry) {
 			group_ctx->groups = talloc_zero(group_ctx, rlm_sql_grouplist_t);
 			entry = group_ctx->groups;
 		} else {