From: Noel Power Date: Fri, 24 May 2019 13:37:00 +0000 (+0000) Subject: CVE-2019-14907 lib/util/charset: clang: Fix Value stored to 'reason' is never read... X-Git-Tag: samba-4.9.18~4 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=030fa9e5455125e30b71c90be80baadb657d8993;p=thirdparty%2Fsamba.git CVE-2019-14907 lib/util/charset: clang: Fix Value stored to 'reason' is never read warning Fixes: lib/util/charset/convert_string.c:301:5: warning: Value stored to 'reason' is never read <--[clang] BUG: https://bugzilla.samba.org/show_bug.cgi?id=14208 Signed-off-by: Noel Power Reviewed-by: Gary Lockyer gary@catalyst.net.nz (cherry picked from commit add47e288bc80c1bf45765d1588a9fa5998ea677) --- diff --git a/lib/util/charset/convert_string.c b/lib/util/charset/convert_string.c index 196302aacfd..34facab6fe6 100644 --- a/lib/util/charset/convert_string.c +++ b/lib/util/charset/convert_string.c @@ -300,13 +300,13 @@ bool convert_string_handle(struct smb_iconv_handle *ic, { reason="No more room"; if (from == CH_UNIX) { - DEBUG(3,("E2BIG: convert_string(%s,%s): srclen=%u destlen=%u - '%s'\n", + DEBUG(3,("E2BIG: convert_string(%s,%s): srclen=%u destlen=%u - '%s' error: %s\n", charset_name(ic, from), charset_name(ic, to), - (unsigned int)srclen, (unsigned int)destlen, (const char *)src)); + (unsigned int)srclen, (unsigned int)destlen, (const char *)src, reason)); } else { - DEBUG(3,("E2BIG: convert_string(%s,%s): srclen=%u destlen=%u\n", + DEBUG(3,("E2BIG: convert_string(%s,%s): srclen=%u destlen=%u error: %s\n", charset_name(ic, from), charset_name(ic, to), - (unsigned int)srclen, (unsigned int)destlen)); + (unsigned int)srclen, (unsigned int)destlen, reason)); } break; }