From: Mark Andrews Date: Wed, 5 Feb 2020 05:37:33 +0000 (+1100) Subject: 'closest' must be non NULL, remove test. X-Git-Tag: v9.16.0~29^2~6 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0312e73e16e329ab7dd43a5e0fd4ec42af0d56c8;p=thirdparty%2Fbind9.git 'closest' must be non NULL, remove test. 6412 cleanup: 6413 dns_rdataset_disassociate(&neg); 6414 dns_rdataset_disassociate(&negsig); CID 1452700 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking closest suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 6415 if (closest != NULL) 6416 free_noqname(mctx, &closest); --- diff --git a/lib/dns/rbtdb.c b/lib/dns/rbtdb.c index e2c9df1cf4c..97c328041df 100644 --- a/lib/dns/rbtdb.c +++ b/lib/dns/rbtdb.c @@ -6412,8 +6412,7 @@ addclosest(dns_rbtdb_t *rbtdb, rdatasetheader_t *newheader, cleanup: dns_rdataset_disassociate(&neg); dns_rdataset_disassociate(&negsig); - if (closest != NULL) - free_noqname(mctx, &closest); + free_noqname(mctx, &closest); return(result); }