From: Nick Mathewson <nickm@torproject.org>
Date: Tue, 6 Aug 2013 20:41:53 +0000 (-0400)
Subject: Use SOCKET_OK/TOR_INVALID_SOCKET in socketpair replacement code
X-Git-Tag: tor-0.2.4.17-rc~5^2~10^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=031e695aa50f24000ec112d535636807167be436;p=thirdparty%2Ftor.git

Use SOCKET_OK/TOR_INVALID_SOCKET in socketpair replacement code
---

diff --git a/src/common/compat.c b/src/common/compat.c
index 69eb0643d0..bf6a0a4243 100644
--- a/src/common/compat.c
+++ b/src/common/compat.c
@@ -1225,9 +1225,9 @@ tor_socketpair(int family, int type, int protocol, tor_socket_t fd[2])
      * for now, and really, when localhost is down sometimes, we
      * have other problems too.
      */
-    tor_socket_t listener = -1;
-    tor_socket_t connector = -1;
-    tor_socket_t acceptor = -1;
+    tor_socket_t listener = TOR_INVALID_SOCKET;
+    tor_socket_t connector = TOR_INVALID_SOCKET;
+    tor_socket_t acceptor = TOR_INVALID_SOCKET;
     struct sockaddr_in listen_addr;
     struct sockaddr_in connect_addr;
     int size;
@@ -1306,11 +1306,11 @@ tor_socketpair(int family, int type, int protocol, tor_socket_t fd[2])
   tidy_up_and_fail:
     if (saved_errno < 0)
       saved_errno = errno;
-    if (listener != -1)
+    if (SOCKET_OK(listener))
       tor_close_socket(listener);
-    if (connector != -1)
+    if (SOCKET_OK(connector))
       tor_close_socket(connector);
-    if (acceptor != -1)
+    if (SOCKET_OK(acceptor))
       tor_close_socket(acceptor);
     return -saved_errno;
 #endif