From: Andreas Schneider Date: Mon, 8 Jul 2024 09:12:02 +0000 (+0200) Subject: s4:torture: Initialize struct smb_nttrans X-Git-Tag: tdb-1.4.11~129 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=03283dfae275ee9960cdc0ed6b1002c79d706eb4;p=thirdparty%2Fsamba.git s4:torture: Initialize struct smb_nttrans "Error: UNINIT (CWE-457): samba-4.20.0rc2/source4/torture/basic/scanner.c:368: var_decl: Declaring variable ""parms"" without initializer. samba-4.20.0rc2/source4/torture/basic/scanner.c:388: uninit_use_in_call: Using uninitialized value ""parms.in.setup"" when calling ""smb_raw_nttrans"". 386| parms.in.data = ntdata_blob; 387| 388|-> status = smb_raw_nttrans(cli->tree, mem_ctx, &parms); 389| 390| if (NT_STATUS_IS_ERR(status)) {" Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner --- diff --git a/source4/torture/basic/scanner.c b/source4/torture/basic/scanner.c index 567b25e788b..335179f82bb 100644 --- a/source4/torture/basic/scanner.c +++ b/source4/torture/basic/scanner.c @@ -365,7 +365,7 @@ static NTSTATUS try_nttrans(struct smbcli_state *cli, int param_len, int data_len, int *rparam_len, int *rdata_len) { - struct smb_nttrans parms; + struct smb_nttrans parms = {}; DATA_BLOB ntparam_blob, ntdata_blob; TALLOC_CTX *mem_ctx; NTSTATUS status;