From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Tue, 21 Jun 2022 07:40:30 +0000 (+0200)
Subject: Process review comments
X-Git-Tag: auth-4.8.0-alpha0~50^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0332ebf65b0b75639d0514028ca5ebd90ded5b42;p=thirdparty%2Fpdns.git

Process review comments
---

diff --git a/pdns/nod.cc b/pdns/nod.cc
index 6dc93a233a..133323c5b3 100644
--- a/pdns/nod.cc
+++ b/pdns/nod.cc
@@ -108,7 +108,7 @@ bool PersistentSBF::init(bool ignore_pid) {
       }
     }
     catch (const filesystem::filesystem_error& e) {
-      SLOG(g_log<<Logger::Warning<<"NODDB init failed:: " << e.what() << endl,
+      SLOG(g_log<<Logger::Warning<<"NODDB init failed: " << e.what() << endl,
            log->error(Logr::Warning, e.what(), "NODDB init failed", "exception", Logging::Loggable("filesystem::filesystem_error")));
       return false;
     }
diff --git a/pdns/unix_utility.cc b/pdns/unix_utility.cc
index 763885916f..35713eee1f 100644
--- a/pdns/unix_utility.cc
+++ b/pdns/unix_utility.cc
@@ -102,8 +102,9 @@ void Utility::setBindAny(int af, sock_t sock)
 #ifdef IPV6_BINDANY
   if (af == AF_INET6) {
     if (setsockopt(sock, IPPROTO_IPV6, IPV6_BINDANY, &one, sizeof(one)) < 0) {
+      int err = errno;
       SLOG(g_log<<Logger::Warning<<"Warning: IPV6_BINDANY setsockopt failed: "<<stringerror(err)<<endl,
-           g_slog->withName("runtime")->error(Logr::Warning, err, ""Warning: IPV6_BINDANY setsockopt failed"));
+           g_slog->withName("runtime")->error(Logr::Warning, err, "Warning: IPV6_BINDANY setsockopt failed"));
     }
   }
 #endif